Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diskio plugin: make devices glob also match devlinks #5817

Merged
merged 1 commit into from
May 15, 2019
Merged

Diskio plugin: make devices glob also match devlinks #5817

merged 1 commit into from
May 15, 2019

Conversation

omgold
Copy link
Contributor

@omgold omgold commented May 8, 2019

Feature request is #5815

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@omgold omgold mentioned this pull request May 8, 2019
Closed
@glinton glinton added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label May 13, 2019
@glinton
Copy link
Contributor

glinton commented May 13, 2019

Can you run make fmt and push so the tests will run, thanks.

@danielnelson
Copy link
Contributor

Will need to make sure you run make fmt with go 1.11 to get it to pass, there is also a legit test failure in there:

# github.com/influxdata/telegraf/plugins/inputs/diskio
plugins/inputs/diskio/diskio_linux_test.go:91:42: multiple-value s.diskName() in single-value context

@omgold
Copy link
Contributor Author

omgold commented May 15, 2019

Okay, next iteration. Changes should fix the problems pointed out above.

@danielnelson danielnelson added this to the 1.11.0 milestone May 15, 2019
@danielnelson danielnelson merged commit 12831f4 into influxdata:master May 15, 2019
hwaastad pushed a commit to hwaastad/telegraf that referenced this pull request Jun 13, 2019
Allow devices option to match against devlinks (influxdata#5817)
ce07f5f
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
@bitcharmer
Allow devices option to match against devlinks (influxdata#5817)
d344970
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
Allow devices option to match against devlinks (influxdata#5817)
ae03889
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
Allow devices option to match against devlinks (influxdata#5817)
cdebdf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glinton glinton glinton approved these changes

Assignees
No one assigned
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@omgold @glinton @danielnelson