Elasticsearch Input changes #6004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 18, 2019 15:03
Like described in influxdata#2650, the current implementation of isMaster was incorrect. As calls were done concurrently, the isMaster value was prone to a race condition. Also when multiple elasticsearch clusters were specified, this was broken. To fix this, a map was added which contains the nodeID and masterID. So for each node we know which one is master (if nodeID == masterID). Test data taken from existing pull request.
The metric number_of_in_flight_fetch was not used in the cluster health. Add it and sort the fields like they are printed by ElasticSearch. Closes: influxdata#2779
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2711
closes #2650
Required for all PRs:
Fixing some long-standing issues in the elasticsearch plugin.
Still a lot of work todo, as it seems like ES6 isn't working correctly anymore?
Any chance to review (and eventrually merge) this first?
Cause I don't want to spend more time on fixing next issues if the base isn't going to be accepted :)