Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory_usage (percent) field to procstat input plugin #6249

Merged

Conversation

sgtsquiggs
Copy link
Contributor

@sgtsquiggs sgtsquiggs commented Aug 13, 2019

I needed it and gopsutils already provides it.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@sgtsquiggs sgtsquiggs force-pushed the procstat_add_memory_usage branch from 9a8d923 to f17f399 Compare August 13, 2019 20:27
@danielnelson danielnelson added this to the 1.12.0 milestone Aug 14, 2019
@danielnelson danielnelson added area/procstat feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Aug 14, 2019
@danielnelson danielnelson merged commit e36639b into influxdata:master Aug 14, 2019
@danielnelson
Copy link
Contributor

Normally I don't like to add computed values, sticking to raw values, but I think in this case cpu/memory percent are okay due to how often they are needed.

bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
@rsaffi
Copy link

rsaffi commented Oct 24, 2019

https://github.com/influxdata/telegraf/blob/master/plugins/inputs/procstat/README.md was not updated to reflect the new field.

@danielnelson
Copy link
Contributor

Thanks @rsaffi, I added it in 2754a48

athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
hprajapati-splunk pushed a commit to hprajapati-splunk/telegraf that referenced this pull request Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/procstat feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants