Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gathering of RabbitMQ federation link metrics. #6283

Merged
merged 5 commits into from
Oct 24, 2019
Merged

Add gathering of RabbitMQ federation link metrics. #6283

merged 5 commits into from
Oct 24, 2019

Conversation

jacquesh
Copy link
Contributor

Add gathering of metrics for the built-in Federation plugin for RabbitMQ.

Closes #6274.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

glinton
glinton suggested changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@glinton glinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just some minor changes from me

plugins/inputs/rabbitmq/README.md Outdated Show resolved Hide resolved
plugins/inputs/rabbitmq/README.md Outdated Show resolved Hide resolved
plugins/inputs/rabbitmq/rabbitmq.go Show resolved Hide resolved
@glinton glinton added area/rabbitmq feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Aug 26, 2019
glinton
glinton approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@glinton glinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

danielnelson
danielnelson suggested changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@danielnelson danielnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there a couple things I think we should tweak before merging.

plugins/inputs/rabbitmq/rabbitmq.go Outdated Show resolved Hide resolved
plugins/inputs/rabbitmq/rabbitmq.go Show resolved Hide resolved
plugins/inputs/rabbitmq/rabbitmq.go Outdated Show resolved Hide resolved
@danielnelson danielnelson added this to the 1.13.0 milestone Sep 19, 2019
@jacquesh jacquesh requested a review from danielnelson October 21, 2019 05:48
@danielnelson danielnelson merged commit 8b3a8d1 into influxdata:master Oct 24, 2019
@danielnelson
Copy link
Contributor

Thank you!

@jacquesh jacquesh deleted the feature/rabbitmq-federation-stats branch November 4, 2019 12:25
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
@jacquesh
Add gathering of RabbitMQ federation link metrics (influxdata#6283)
c16f7ad
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
@jacquesh
Add gathering of RabbitMQ federation link metrics (influxdata#6283)
8059d65
@pabigot pabigot mentioned this pull request Jul 14, 2021
Closed
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@jacquesh @danielnelson
Add gathering of RabbitMQ federation link metrics (influxdata#6283)
47098c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glinton glinton glinton approved these changes

@danielnelson danielnelson danielnelson approved these changes

Assignees
No one assigned
Labels
area/rabbitmq feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Add stats for RabbitMQ's Federation plugin when it is available/in use
3 participants
@jacquesh @danielnelson @glinton