-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to fork of sarama without zstd dependency #6349
Conversation
(cherry picked from commit 11d40a9)
Unfortunately, that commit Should use latest commit https://github.com/influxdata/sarama/commit/d6c39e51b1aa805d23878ebe101a30675dc17866 instead? |
Looks like it exists on the |
Got it- for some reason github search doesn't find that commit, opened a ticket. Working on #6118 I still can't get modules to work for sarama (posting here as the forked sarama repo doesn't support issues). My
yet:
I think that the fork needs to have an updated module name in Does that make sense? The I'd be happy to open a PR. |
(cherry picked from commit 11d40a9)
The newer sarama library uses CGO for it's zstd compression. Telegraf does not support enabling zstd compression currently, so it is safe to remove. This avoids the build requiring GLIBC_2.14, but we may want to make further changes to the build to avoid linking newer symbol versions.
Changes against sarama 1.23.1: https://github.com/influxdata/sarama/commit/b12709e6ca29240128c89fe0b30b6a76be42b457
closes #6344
Required for all PRs: