-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prometheus serializer and use it in prometheus output #6703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
added
feat
Improvement on an existing feature such as adding a new setting/mode to an existing plugin
area/prometheus
new plugin
labels
Nov 22, 2019
This was referenced Nov 22, 2019
reimda
reviewed
Nov 22, 2019
reimda
reviewed
Nov 22, 2019
reimda
approved these changes
Nov 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a full telegraf->prometheus->telegraf test? Maybe I missed it.
I'll do a roundtrip test as a follow-up pr since it will involve some changes to testutil which will then require quite a number of unittest changes. |
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
3 tasks
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/prometheus
feat
Improvement on an existing feature such as adding a new setting/mode to an existing plugin
new plugin
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a prometheus serializer, with support for round tripping
metric_version=2
of theprometheus
input.related #4414
Use this serializer in the Prometheus output when
metric_version=2
. Formally deprecate metric_version = 1 in both the input and the output plugin.closes #4415
Add
use_batch_format
support to the file output, similar to support in the amqp and kafka outputs. This is a move away from theSerialize
function towards theSerializeBatch
function in the Serializer interface, which allows for more efficient writing and writing multiple metrics to a destination. In regards to the prometheus serializer, the batch format is required in order to group metric families and to write histogram and summary types correctly.There is a known bug introduced in this pull request, since histogram or summary metrics are split over multiple telegraf.Metric's, it is possible that a batch of metrics will contain only part of a histogram/summary . I documented this in the serializer docs. This issue makes me wonder if we need a way to "group" metrics for the purposes of batching?
Required for all PRs: