MySQL - Option for collecting global variables #6790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Readme: Added line for boolean config for collecting global vars - mysql.go: added line to retrieve config value - mysql.go: added logic to either collect or not collect vars based on config Co-Authored-By: Matthew Iverson <esity@users.noreply.github.com>
|
@danielnelson & @glinton |
danielnelson
suggested changes
Dec 11, 2019
plugins/inputs/mysql/mysql.go
Outdated
| @@ -94,6 +95,9 @@ const sampleConfig = ` | |||
| ## gather metrics from SHOW BINARY LOGS command output | |||
| # gather_binary_logs = false | |||
|
|
|||
| ## gather metrics from PERFORMANCE_SCHEMA.GLOBAL_VARIABLES | |||
| # gather_global_variables = false | |||
There was a problem hiding this comment.
This was previously always enabled, so we should display this as true here and initialize it to true in the plugins init() function.
danielnelson
added
area/mysql
feat
danielnelson
approved these changes
Dec 11, 2019
danielnelson
pushed a commit
that referenced
this pull request
Dec 11, 2019
(cherry picked from commit 4def7cc)
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #6789
There should be a config value that allows for enabling/disabling collection of MySQL Global Variables.
closes #6789
Required for all PRs: