Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert snmp_trap_test.go to table test #6803

Merged
merged 3 commits into from
Dec 17, 2019
Merged

Convert snmp_trap_test.go to table test #6803

merged 3 commits into from
Dec 17, 2019

Conversation

reimda
Copy link
Contributor

@reimda reimda commented Dec 13, 2019

Also add a test for v1 generic trap and fix a bug in v1 generic trap where generic oid was missing its leading period.

@reimda reimda requested a review from danielnelson December 13, 2019 23:45
@danielnelson danielnelson added this to the 1.13.1 milestone Dec 14, 2019
@danielnelson danielnelson added area/snmp feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin fix pr to fix corresponding bug and removed feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Dec 14, 2019
@reimda reimda merged commit 99279e6 into master Dec 17, 2019
@reimda reimda deleted the snmp_trap-table-test branch December 17, 2019 22:12
reimda added a commit that referenced this pull request Dec 17, 2019
Add a test for v1 generic trap.  Add missing leading period in v1 generic trap oid.

(cherry picked from commit 99279e6)
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
Add a test for v1 generic trap.  Add missing leading period in v1 generic trap oid.
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
Add a test for v1 generic trap.  Add missing leading period in v1 generic trap oid.
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Add a test for v1 generic trap.  Add missing leading period in v1 generic trap oid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/snmp fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants