Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse NaN values from summary types in prometheus input #6997

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

danielnelson
Copy link
Contributor

Parse NaN values from summary types with prometheus metric_version = 2. Missing data in the output was caused by not having any quantile values.

Note that line protocol does not support NaN values, so these won't appear when when using --test.

closes #6988

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added the fix pr to fix corresponding bug label Feb 7, 2020
@danielnelson danielnelson added this to the 1.13.4 milestone Feb 7, 2020
@danielnelson danielnelson requested a review from reimda February 7, 2020 20:05
@danielnelson danielnelson merged commit 0710cc7 into master Feb 10, 2020
@danielnelson danielnelson deleted the prom-v2-nan-summary branch February 10, 2020 22:18
danielnelson added a commit that referenced this pull request Feb 10, 2020
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics of type Summary has been dropped
2 participants