Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed supported versions to include 7.0 #9486

Closed
wants to merge 1 commit into from

Conversation

prydin
Copy link
Contributor

@prydin prydin commented Jul 9, 2021

  • Updated associated README.md.
  • Wrote appropriate unit tests.

resolves #9102

Added 7.0 to list of supported vCenter versions.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jul 9, 2021
@sspaink
Copy link
Contributor

sspaink commented Jul 10, 2021

Thank you for this pull request! So it looks like Telegraf is using v0.19 of the library that interacts with the VMware VSphere API's (Link to go.mod in master) and that version doesn't officially state it supports v7.0 only v6.7: https://github.com/vmware/govmomi/tree/v0.19.0#compatibility

It might be a good idea to go ahead and update the go vsphere client library to the latest (from v0.19->v0.26) which does officially state it supports v7.0. @prydin do you think you could do this as well in this pull request?

@sspaink
Copy link
Contributor

sspaink commented Jul 28, 2021

I've created a new pr with this same change in the README but then also updated the Go library used by the plugin. Closing this in favor of the new PR: #9552

@sspaink sspaink closed this Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[input.vsphere] Support vSphere version 7.0
2 participants