Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix Snmp empty metric name #9519

Merged
merged 8 commits into from
Jul 27, 2021
Merged

Bug Fix Snmp empty metric name #9519

merged 8 commits into from
Jul 27, 2021

Conversation

MyaLongmire
Copy link
Contributor

@MyaLongmire MyaLongmire commented Jul 19, 2021

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.

resolves #8840 and pull request #9366

Gave name to ifName processor

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jul 19, 2021
@MyaLongmire
Copy link
Contributor Author

@Hipska Will you please test this with ifName just to double check?

@MyaLongmire MyaLongmire changed the title Snmp empty metric name Bug Fix Snmp empty metric name Jul 19, 2021
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MyaLongmire thanks for looking into this!
However, I have some concerns relaxing the conditions here as it opens the door for configuration errors... I would prefer to set t.Name to something non-empty and leave t.Oid empty OR have an explicit flag to ignore that condition that can be used by the ifName processor.

@MyaLongmire
Copy link
Contributor Author

Hey @MyaLongmire thanks for looking into this!
However, I have some concerns relaxing the conditions here as it opens the door for configuration errors... I would prefer to set t.Name to something non-empty and leave t.Oid empty OR have an explicit flag to ignore that condition that can be used by the ifName processor.

@srebhan I have changed it back to an error. I also gave the ifName processor a name so it will not error. Thank you for looking this over!

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that's really smart! Looks nice to me. Thanks for squashing this one. :-)

@srebhan srebhan self-assigned this Jul 21, 2021
@srebhan srebhan added area/snmp ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Jul 21, 2021
@srebhan
Copy link
Member

srebhan commented Jul 21, 2021

Oh @MyaLongmire, please adapt the PR description as it no longer matches your fix.

@srebhan srebhan added the fix pr to fix corresponding bug label Jul 21, 2021
plugins/processors/ifname/ifname.go Outdated Show resolved Hide resolved
Copy link
Member

@helenosheaa helenosheaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Thomas Casteleyn <thomas.casteleyn@super-visions.com>
@MyaLongmire MyaLongmire merged commit a48e11d into master Jul 27, 2021
@MyaLongmire MyaLongmire deleted the snmp-empty-metric-name branch July 27, 2021 20:34
reimda pushed a commit that referenced this pull request Jul 28, 2021
phemmer added a commit to phemmer/telegraf that referenced this pull request Aug 13, 2021
* origin/master: (183 commits)
  fix: CrateDB replace dots in tag keys with underscores (influxdata#9566)
  feat: Pull metrics from multiple AWS CloudWatch namespaces (influxdata#9386)
  fix: improve Clickhouse corner cases for empty recordset in aggregation queries, fix dictionaries behavior (influxdata#9401)
  fix(opcua): clean client on disconnect so that connect works cleanly (influxdata#9583)
  fix: Refactor ec2 init for config-api (influxdata#9576)
  fix: sort logs by timestamp before writing to Loki (influxdata#9571)
  fix: muting tests for udp_listener (influxdata#9578)
  fix: Do not return on disconnect to avoid breaking reconnect (influxdata#9524)
  fix: Fixing k8s nodes and pods parsing error (influxdata#9581)
  feat: OpenTelemetry output plugin (influxdata#9228)
  feat: Support AWS Web Identity Provider (influxdata#9411)
  fix: upgraded sensu/go to v2.9.0 (influxdata#9577)
  fix: Normalize unix socket path (influxdata#9554)
  docs: fix aws ec2 readme inconsistency (influxdata#9567)
  feat: Modbus Rtu over tcp enhancement (influxdata#9570)
  docs: information on new conventional commit format (influxdata#9573)
  docs: Add logo (influxdata#9574)
  docs: Adding links to net_irtt and dht_sensor external plugins (influxdata#9569)
  Upgrade hashicorp/consul/api to 1.9.1 (influxdata#9565)
  Update vmware/govmomi to v0.26.0 (influxdata#9552)
  Do not skip good quality nodes after a bad quality node is encountered (influxdata#9550)
  fix test so it hits a fake service (influxdata#9564)
  Update changelog
  Fix procstat plugin README to match sample config (influxdata#9553)
  Fix metrics reported as written but not actually written  (influxdata#9526)
  Prevent segfault in persistent volume claims (influxdata#9549)
  Update procstat to support cgroup globs & include systemd unit children (Copy of influxdata#7890) (influxdata#9488)
  Fix attempt to connect to an empty list of servers. (influxdata#9503)
  Fix handling bool in sql input plugin (influxdata#9540)
  Suricata alerts (influxdata#9322)
  Linter fixes for plugins/inputs/[fg]* (influxdata#9387)
  For Prometheus Input add ability to query Consul Service catalog (influxdata#5464)
  Support Landing page on Prometheus landing page (influxdata#8641)
  [Docs] Clarify tagging behavior (influxdata#9461)
  Change the timeout from all queries to per query (influxdata#9471)
  Attach the pod labels to the `kubernetes_pod_volume` & `kubernetes_pod_network` metrics. (influxdata#9438)
  feat(http_listener_v2): allows multiple paths and add path_tag (influxdata#9529)
  Bug Fix Snmp empty metric name (influxdata#9519)
  Worktable workfile stats (influxdata#8587)
  Update Go to v1.16.6 (influxdata#9542)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/snmp feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNMP input can produce metrics with empty metric name
5 participants