fix: outputs.opentelemetry use attributes setting #9588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jacobmarble Could you take a look at this otel output change? Thanks! |
codeboten
force-pushed
the
codeboten/use-attributes
branch
from
8d852c4
to
edfdfa6
Compare
|
@reimda @jacobmarble just marked this opened now that #9587 has been merged, please take a look. |
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
jacobmarble
approved these changes
Sep 7, 2021
sspaink
approved these changes
Sep 7, 2021
reimda
pushed a commit
that referenced
this pull request
Sep 17, 2021
(cherry picked from commit 147e3d1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Following the discussion here, the attributes setting was not being utilized in the opentelemetry output plugin. This PR fixes that by upserting the attributes configured into the resource before emitting it.
This is a followup to #9587