fix: pagination error on cloudwatch plugin #9693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the error of InvalidParameterValue: Parameters do not match original request parameters as the current code dont use correctly the return token from aws client
|
Thanks so much for the pull request! |
telegraf-tiger
bot
added
the
feat
akrantz01
added
area/aws
akrantz01
suggested changes
Aug 30, 2021
|
!signed-cla |
|
@Doron-Bargo looks like the CI is failing due to a minor formatting issue, you can resolve it by running Thanks for digging into this issue and finding a fix! |
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
sspaink
added
the
ready for final review
reimda
pushed a commit
that referenced
this pull request
Sep 17, 2021
(cherry picked from commit 646273a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the error of InvalidParameterValue: Parameters do not match original request parameters as the current code dont use correctly the return token from aws client
Required for all PRs:
Following the discussion on PR #9386 (the update to support multiple namespaces in cloudwatch input plugin ) the latest change keep the token pagination to the next namespace which result in an error of InvalidParameterValue: Parameters do not match original request parameters. This change is to fix this error.
I moved the namespace loop and the aws param initialization to be outside the loop of the pagination