Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing semicolon in Readme #13

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

williamhurst-nickycard
Copy link
Contributor

The missing semicolon causes a compiletime error if the code is copied as is. This could be confusing for new developers.

The missing semicolon causes a compiletime error if the code is copied as is. This could be confusing for new developers.
@josipk-ib
Copy link
Contributor

Thank you for your contribution. We are encouraging developers to keep suggesting the improvements and opening issues for any bugs they found. However we will not accept the PR (as stated in our contribution) because of our automated workflow for publishing the source code here to GitHub from our internal repository. We will make the change you suggested in our internal repository and publish it here. Thank you again and keep in mind we appreciate your involvement.

Copy link
Contributor

@ibirogar ibirogar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@ibirogar ibirogar merged commit a2fa760 into infobip:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants