-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Go version to 1.21+ and add support for new object #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JkhatriInfobox
commented
Jun 20, 2024
- Added support for the Zone Forward object
- Added new structure to handle Nullable list on Forward Zone
- Upgraded Go support from 1.17 to 1.21 and above
- Updated dependencies on vendor dir
* [ADD] Support zone_forward DNS object * [IMP] Updated Go Version to support 1.21 and above with updating dependent libs. * [FIX] removing omitempty tag for ns_group field of zone_forward record. * [FIX] removing omitempty tage for ForwardingServers in zone forward record. * [FIX] adding omitempty tags for forwarding_servers field and adding omitempty to ns_group field of forward zone record * [FIX] NIOS-101148: adding wrapper struct for forwarding-servers to support setting, unsetting and modifying the field.
* Add release notes and changelog * Update CHANGELOG.md
JchhatbarInfoblox
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nitish-ks
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Aish-sp
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.