-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for the ForwardZone and upgraded Terraform and Go Lang version #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ADD] Support Zone Forward Resource and DataSource. * [IMP] Updated go mod tosupport go version to 1.21 and above, updated vendor dir. * [FIX] unsetting ns_group field for forward_zone record. * [FIX] NIOS-101119 custom forwarders configuration in forward zone.
* Fix | NIOS-101231 | Added enable dns to return fields. * Removed go-client debug replacement in go.mod
…#359) * [ADD] Add support for external_ns_group for FOWARD ZONE resource and datasource. * [FIX] Forward Zone CRUD with empty FORWARD_TO when external_ns_group defined. * Resolve rebase conflict with dev2.7 branch * Resolve conflict * Fix | NIOS-101231 | Added enable dns to return fields. * Removed go-client debug replacement in go.mod * Updated go.mod and vendor dir * Updated zone_forward datasource * Updated zone_forward resource read operation to set forward_to value * Remove redundant code from zone forward resource_infoblox_zone_forward.go. --------- Co-authored-by: Jaykumar Chhatbar <45447272+JchhatbarInfoblox@users.noreply.github.com>
* [FIx] BUG-NPA-35 to support import with both external_ns_group and ns_group * [FIx] Queryparam pointer for forward zone datasource_infoblox_zone_forward.go
* Adding examples for resource and datasource for zone-forward * Update infoblox_zone_forward.tf
* Added document for host record, IPv6 network and container. * Added document for host record, IPv6 network and container. * incorporated review comments
#368) * Update wapi version to 2.9 in provider and updated website and Git doc * Updated go version in '.go-version' file with verison 1.21
* Updated infoblox-go-client version 2.6.0 to 2.7.0 * [IMP] Updated vendor directory for infoblox-go-client v2.7.0
* Updated changelog.md and readme.md for 2.7.0 release * incorporated review comments
JchhatbarInfoblox
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Aish-sp
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Resource:
Added Datasource