Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP #1032

Draft
wants to merge 66 commits into
base: main
Choose a base branch
from

Conversation

make-github-pseudonymous-again
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 88.92889% with 123 lines in your changes missing coverage. Please review.

Project coverage is 75.43%. Comparing base (28c94e2) to head (3e41278).

Files Patch % Lines
imports/api/query/watch.ts 75.22% 21 Missing and 6 partials ⚠️
imports/api/publication/subscribe.ts 55.00% 9 Missing and 9 partials ⚠️
imports/api/createTagCollection.ts 23.07% 10 Missing ⚠️
imports/api/makeObservedQueryPublication.ts 0.00% 10 Missing ⚠️
imports/api/makeObservedQueryHook.ts 0.00% 9 Missing ⚠️
imports/api/publication/useFind.ts 78.57% 9 Missing ⚠️
imports/api/publication/stats/frequencyBySex.ts 86.66% 5 Missing and 3 partials ⚠️
imports/api/publication/stopSubscription.ts 77.41% 3 Missing and 4 partials ⚠️
imports/api/publication/publishCursors.tests.ts 96.03% 4 Missing ⚠️
imports/lib/async/defer.ts 88.57% 2 Missing and 2 partials ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
+ Coverage   66.62%   75.43%   +8.81%     
==========================================
  Files         719      420     -299     
  Lines       10006     7347    -2659     
  Branches     1349      692     -657     
==========================================
- Hits         6666     5542    -1124     
+ Misses       2879     1561    -1318     
+ Partials      461      244     -217     
Flag Coverage Δ
client 46.47% <80.50%> (+0.28%) ⬆️
server 59.49% <40.50%> (-3.14%) ⬇️
test 76.03% <89.12%> (+3.48%) ⬆️
test-app 40.35% <17.45%> (-13.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@make-github-pseudonymous-again make-github-pseudonymous-again force-pushed the refactor-use-change-streams-in-make-observed-query-publication-1-draft branch from 1aa42bc to 46508ff Compare July 27, 2024 12:47
@make-github-pseudonymous-again make-github-pseudonymous-again force-pushed the refactor-use-change-streams-in-make-observed-query-publication-1-draft branch from 46508ff to 3e41278 Compare July 27, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant