Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tags only for semver and default branch #82

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

p-offtermatt
Copy link
Member

Closes: #81

Right now, tags are generated for a lot of Docker images that are generated by the automated workflow https://github.com/informalsystems/CometMock/blob/ph/produce-less-tagged-images/.github/workflows/docker-publish.yml

This should be adjusted to have only the following tags auto-generated:

  • main
  • nightly
  • 0.x.x semver-tagged images

@p-offtermatt p-offtermatt force-pushed the ph/produce-less-tagged-images branch 3 times, most recently from c6918a2 to 989bda8 Compare October 17, 2023 11:54
@p-offtermatt p-offtermatt added A:backport/v0.34.x When a PR labelled with this label is merged, it will automatically be backported to v0.34.x A:backport/v0.37.x When a PR labelled with this label is merged, it will automatically be backported to v0.37.x A:backport/v0.38.x When a PR labelled with this label is merged, it will automatically be backported to v0.38.x labels Oct 17, 2023
@p-offtermatt p-offtermatt merged commit 25d5b47 into main Oct 18, 2023
3 checks passed
mergify bot pushed a commit that referenced this pull request Oct 18, 2023
mergify bot pushed a commit that referenced this pull request Oct 18, 2023
mergify bot pushed a commit that referenced this pull request Oct 18, 2023
p-offtermatt added a commit that referenced this pull request Oct 18, 2023
(cherry picked from commit 25d5b47)

Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>
p-offtermatt added a commit that referenced this pull request Oct 18, 2023
(cherry picked from commit 25d5b47)

Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>
p-offtermatt added a commit that referenced this pull request Oct 18, 2023
(cherry picked from commit 25d5b47)

Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>
p-offtermatt added a commit that referenced this pull request Nov 27, 2023
* Update README.md

* Refactor: remove isConnected

* Add test for Abci query

* Enable tags only for semver and default branch (#82)

* Add fine-grained control of time (#88)

* Start implementing auto-include-tx flag

* Split testnet initialization and run

* Add script to restart testnet from beginning

* Start implementing auto-include-tx flag

* Delete backup directory before taking backup

* Uncomment killing processes with app binary

* Rewrite TxQueue

* Fix fire events method

* Implement tx filtering and rechecks

* Start implementing basic test for Tx effect

* Ensure the script is not blocking

* Rename Dockerfile-test to Dockerfile.test

* Add Contains method

* Remove initial setup from Dockerfile

* Remove sleep and add -p 1

* Use big.Int for community pool size

* Use testnet restart in tests instead of a new setup each time

* Add cometmock args to be taken by startup script

* Pull time handling into TimeHandler class

* Fix CheckTx and time

* Add test cases for AutoTx and block production

* Add time control to README

* Fix auto-tx flag

* Add test for starting timestamp

* Add test for starting time=system time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v0.34.x When a PR labelled with this label is merged, it will automatically be backported to v0.34.x A:backport/v0.37.x When a PR labelled with this label is merged, it will automatically be backported to v0.37.x A:backport/v0.38.x When a PR labelled with this label is merged, it will automatically be backported to v0.38.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Too many docker images with tags
1 participant