Fix init value for List and nondet value for constructors with no params #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lists in rust actually type constructors, and we were treating them as concrete types
Add a hack to introduce an empty auxiliary definition to the nondet value, so the end value gets translated to `pure val` (instead of `nondet`) and doesn't have a `.oneOf()`.
p-offtermatt
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
This contains 2 small fixes that I've been saving to test/show the power of our new integration tests. Review by commit and the snapshots should show you exactly the impact of the change.
Some explanation of the changes is also on the commit descriptions, but the snapshots should be of more help.