Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STELLAR-3554 : add support for stream resume, frame bundling #110

Merged
merged 16 commits into from
Jun 4, 2020

Conversation

davidk81
Copy link
Contributor

@davidk81 davidk81 commented Jun 2, 2020

  • support for frame bundling
  • support for stream resume
  • grpc flow control with client telemetry message ack

@danada
Copy link
Contributor

danada commented Jun 3, 2020

I was testing the current release of the CLI and found go-grpc threw an error when the message size was over 4MB or so. I think there's a limit on the client too?

@davidk81
Copy link
Contributor Author

davidk81 commented Jun 4, 2020

do we need to make resumeStreamMessageAckId into a cli argument so users can manually resume a stream if CLI fails to reconnect automatically?

@davidk81 davidk81 changed the title [Draft] Stream resume, flow control, frame bundling Stream resume, flow control, frame bundling Jun 4, 2020
@davidk81 davidk81 requested a review from woobianca June 4, 2020 03:40
@davidk81 davidk81 changed the title Stream resume, flow control, frame bundling STELLAR-3554 : add support for stream resume, frame bundling Jun 4, 2020
@davidk81
Copy link
Contributor Author

davidk81 commented Jun 4, 2020

i think this is ready for review

@danada
Copy link
Contributor

danada commented Jun 4, 2020

do we need to make resumeStreamMessageAckId into a cli argument so users can manually resume a stream if CLI fails to reconnect automatically?

Do we print the ack ID anywhere? I don't think we need to have an argument for this since the CLI is handling this automatically. I couldn't imagine a user somehow recording the ack ID from CLI output and having a process restart the CLI with the recorded ack ID-- at this point it would be easier to just use the API directly 😄

go.sum Outdated Show resolved Hide resolved
davidk81 and others added 2 commits June 4, 2020 13:42
Co-authored-by: Bianca Woo <18028868+woobianca@users.noreply.github.com>
@davidk81
Copy link
Contributor Author

davidk81 commented Jun 4, 2020

I was testing the current release of the CLI and found go-grpc threw an error when the message size was over 4MB or so. I think there's a limit on the client too?

not sure if this solves that problem, but this might be the way to set maxMessageSize in grpc-go. i didn't bother to figure out how to send messages > 4MB with starpass so i didn't test this.

master...davidk81:adj-grpc-window-size

@davidk81 davidk81 merged commit c9373a4 into infostellarinc:master Jun 4, 2020
@davidk81 davidk81 deleted the stream-resume branch June 4, 2020 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants