STELLAR-3700 - Add option to disable TCP/UDP proxy for streams #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danada
reviewed
Oct 19, 2020
There was a problem hiding this comment.
Can you also update the docs to include the new option? Here's the instructions: https://github.com/infostellarinc/stellarcli/blob/master/util/docs/markdown/README.md
danada
reviewed
Oct 20, 2020
|
@rockets3600 Can you merge master and regenerate the docs? |
danada
approved these changes
Nov 5, 2020
Co-authored-by: Daniel De Sousa <dan.desousa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
A new "disabled" option was added to --proxy flag when opening a stream.
This will allow users to open a stream without opening a tcp/udp proxy.
Since users will be unable to send commands or route data with the proxy, this arg will likely be used in conjunction with the --output-file option.
Example:
./stellarcli satellite open-stream [sat_id] --proxy=disabled --output-file="/output/file"