Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse the config returned by the loadbalancer-api and turn that into a valid haproxy config #15

Merged
merged 18 commits into from
Mar 31, 2023
Merged

Parse the config returned by the loadbalancer-api and turn that into a valid haproxy config #15

merged 18 commits into from
Mar 31, 2023

Conversation

rizzza
Copy link
Contributor

@rizzza rizzza commented Mar 16, 2023 •
edited
Loading

Summary

  • Add nats-cli to dev container
  • Query lb api for load balancer details and merge that with the base haproxy config
  • REST client for lb api
  • lb api url inow s a required cli flag
  • Moved dataplaneclient out of internal/pkg to internal/dataplaneapi

@rizzza
basic haxproxy parse/test
1254766 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
re-work json example keys to match lbapi
14bc17e 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
initialize lb api and require the url
faa9107 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
conditionally use lbapi if set in config
ed5533d 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
align json, struct tags with latest
48299b3 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
disable internal logger
f1d3f25 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
handle pubsub msgs
77f1fd3 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
simpler mgr msg loop
5eb7336 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
lil' polish
01ed07b 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza rizzza marked this pull request as ready for review March 28, 2023 15:55
@rizzza rizzza changed the title Merge haproxy config request Parse the config returned by the loadbalancer-api and turn that into a valid haproxy config Mar 28, 2023
andy-v-h
andy-v-h reviewed Mar 28, 2023
View reviewed changes
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
@rizzza
no apt-clean, install nats-cli
7213e8a 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
re-work lbapi types
665c8e9 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
andy-v-h
andy-v-h previously approved these changes Mar 28, 2023
View reviewed changes
@rizzza
require lbapi url
1d20e3a 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
moving dataplane client from pkg to dataplaneapi package
0afe2bc 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
manager/client unit testing
dfde06a 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
fishnix
fishnix previously approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@fishnix fishnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things - this looks good to me overall! 🎉

internal/lbapi/client.go
@@ -0,0 +1,114 @@
package lbapi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should (eventually) live in the lbapi codebase

internal/lbapi/client.go Show resolved Hide resolved
internal/lbapi/client.go Show resolved Hide resolved
internal/lbapi/client.go Show resolved Hide resolved
internal/lbapi/types.go Outdated Show resolved Hide resolved
internal/pkg/manager.go Outdated Show resolved Hide resolved
internal/pkg/manager.go Outdated Show resolved Hide resolved
@rizzza @fishnix
doc comments
00f4a4a 
Co-authored-by: E Camden Fisher <fish@fishnix.net>
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
inject your own http client
5dc8391 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
comments
a7ad14d 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
translate lbapi resp to local manager types
d35c348 
  * lbapi client will eventually move to load-balancer-api

Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
tylerauerbeck
tylerauerbeck approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@tylerauerbeck tylerauerbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rizzza rizzza merged commit f699f71 into infratographer:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerauerbeck tylerauerbeck tylerauerbeck approved these changes

@fishnix fishnix fishnix approved these changes

@andy-v-h andy-v-h andy-v-h left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rizzza @fishnix @andy-v-h @tylerauerbeck