Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Otel Telemetry #18

Merged
merged 10 commits into from
Sep 20, 2023
Merged

Conversation

sthwang-metal
Copy link
Contributor

@sthwang-metal sthwang-metal commented Aug 25, 2023

Summary of Changes

  • Extracts otel tracing from nats messages, adds relevant tracing and injects it back into nats.
  • Updated to use the new loggingx package
  • Also adds README and Makefile
  • Added returns to Naks

Always looking for feedback especially for where to and where not to trace.

Note: using @date -Iseconds in the Makefile since that works with both my mac and linux date cli.

@sthwang-metal sthwang-metal requested review from a team as code owners August 25, 2023 19:46
@sthwang-metal sthwang-metal marked this pull request as draft August 25, 2023 19:47
@sthwang-metal sthwang-metal force-pushed the sthwang/add-telemetry branch 5 times, most recently from 7f233f2 to e94a8f7 Compare August 26, 2023 00:06
@sthwang-metal sthwang-metal marked this pull request as ready for review August 30, 2023 16:24
Signed-off-by: Stephen Hwang <126002920+sthwang-metal@users.noreply.github.com>
Signed-off-by: Stephen Hwang <126002920+sthwang-metal@users.noreply.github.com>
Signed-off-by: Stephen Hwang <126002920+sthwang-metal@users.noreply.github.com>
Signed-off-by: Stephen Hwang <126002920+sthwang-metal@users.noreply.github.com>
Signed-off-by: Stephen Hwang <126002920+sthwang-metal@users.noreply.github.com>
Signed-off-by: Stephen Hwang <126002920+sthwang-metal@users.noreply.github.com>
Signed-off-by: Stephen Hwang <126002920+sthwang-metal@users.noreply.github.com>
Signed-off-by: Stephen Hwang <126002920+sthwang-metal@users.noreply.github.com>
rizzza
rizzza previously approved these changes Sep 18, 2023
Signed-off-by: Stephen Hwang <126002920+sthwang-metal@users.noreply.github.com>
Signed-off-by: Stephen Hwang <126002920+sthwang-metal@users.noreply.github.com>
@rizzza rizzza merged commit bb0c228 into infratographer:main Sep 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants