Fix QueueSubscribeSync and backoff errors #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, NATS will send requests to all consumers that can respond unless they are part of the same queue group. This commit updates coreSubscribe to use the configured queue group for the connection to ensure only one consumer receives a request. Signed-off-by: John Schaeffer <jschaeffer@equinix.com>
As written, if a message is not received before the context times out in coreSubscribe and jsSubscribe, the subscriber will wait for the duration of the backoff period. This commit updates coreSubscribe and jsSubscribe to not wait to keep processing messages if the current polling iteration simply expired. Signed-off-by: John Schaeffer <jschaeffer@equinix.com>
mikemrm
reviewed
Aug 30, 2023
Signed-off-by: John Schaeffer <jschaeffer@equinix.com>
mikemrm
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core NATS subscriptions were incorrectly using
SubscribeSyncinstead ofQueueSubscribeSyncand both core and JetStream subscriptions were waiting for the backoff period (default 5 seconds) for all iterations of the worker loop, not just error conditions. This PR fixes both issues.