Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add thorough database metadata test #42

Closed
wants to merge 5 commits into from
Closed

Add thorough database metadata test #42

wants to merge 5 commits into from

Conversation

sualeh
Copy link
Contributor

@sualeh sualeh commented Nov 14, 2023

No description provided.

@maximevw
Copy link
Collaborator

Thank you @sualeh for your contribution. I'll have a look on it after fixing issue #39 still in progress.

@sualeh
Copy link
Contributor Author

sualeh commented Nov 22, 2023

@maximevw I will fix the tests after I release the next version of SchemaCrawler. I need to account for the not supported exception on getProcedures. Though I am not sure why the test is passing locally but not on the GitHub Actions build. I will figure that out later. Meanwhile, please ignore this PR.

@maximevw
Copy link
Collaborator

@sualeh No problem, take your time. :) And thank you for taking the previous remarks into account.

@sualeh sualeh closed this Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximevw maximevw maximevw requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sualeh @maximevw