New API #293
Merged
New API #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix memory error in single_stage_multi_reduction_kernel (#235) * Added separate device context struct, returned lde * Montgomery param added in lde.cu mul function --------- Co-authored-by: ImmanuelSegol <3ditds@gmail.com>
* fixed msm_test, int unification, google guilde * Fixed warnings
* fix memory error in single_stage_multi_reduction_kernel (#235) * refactor * refactor * revert * refactor: clang format * Update icicle/appUtils/msm/msm.cu * Added separate device context struct, returned lde * wip - msm and eq * added lde to cmake * Montgomery param added in lde.cu mul function * fixed on_device for ntt and lde * CamelCase * fixed msm_test, int unification, google guilde * wip - ntt crash debugging * async MSM with a rust wrapper * wip ntt tests with corretness * hotfix for correctness > 2^9 * wip on device inout mixing with correctness * cleanup * preserving twiddles after first call * fixed twiddles preserving * formatting * removed some printing * disable ecntt temporarily * format * rust fmt * exclude target from format * passing ntt after merge * hotfix for linking issue * format * format * draft of pr comments + correctness restored * wip refactor + format * domain wip * rust format * Merged feature branch in and Rust MSM correctness * rust build for correct curve * Slowdown fixed by passing release flag to cmake * WIP field and curve * still wip field and curve * field and curve in rust 1.0 * Refactored rust into several crates * Arkworks is now an option, bn254 crate created * Rust msm and ntt wip * A version of rust msm done, cuda runtime wrapped * refactor rust by creating a curve folder * vec_ops instead of lde for now * format --------- Co-authored-by: ImmanuelSegol <3ditds@gmail.com> Co-authored-by: Vitalii <vitalii@ingonyama.com>
* NTT reworked on CUDA side, Rust API updated * Updates to the Rust-side CUDA runtime wrapper * Merged in main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
This PR revamps the API