New API for Version 1.0.0 #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyfelder
requested review from
vhnatyk,
ImmanuelSegol,
DmytroTym,
ChickenLover,
bigsky77 and
LeonHibnik
jeremyfelder
commented
Jan 2, 2024
|
Comments from Vitaliy: #305 (comment) |
vhnatyk
reviewed
Jan 2, 2024
jeremyfelder
commented
Jan 2, 2024
vhnatyk
reviewed
Jan 2, 2024
There was a problem hiding this comment.
the great :)
- Rust tests are finally running without
--test-threads=1✌🏻(upd: turns out not 😢 - but maybe it's just WSL issue?) - Compilation time in release - you still want to do some coffee in the mean time as before 😄 but it's already finished compiling - truly improved 👍🏻
- Almost zero copypaste and no out-of-sync code in scripts 💥
the (not so) good :/
- still not able to do debug build in meaningful time, even for single curve 😕
- maybe worth adding
Cargo.tomlto the root of repo - since rust-analyzer doesn't work ok unless opened rust folder in new vscode window
the (not that) ugly 😳
- a bunch of
.. as *const _ as *const ...- I recall these were cause of mindblowing bugs in the initial release, some easily replacable withas_ptr(), some not - well, maybe it's just me 😏
vhnatyk
reviewed
Jan 3, 2024
Merged
Add curves to Rust, use generics for NTT, MSM and tests
* NTT and MSM bugs fixed and functionality extended * More Rust tests, refactored Rust wrappers * Reworked MSM and NTT public functions on the Rust side --------- Co-authored-by: ImmanuelSegol <3ditds@gmail.com> Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com> Co-authored-by: BigSky77 <simonjudd2@gmail.com> Co-authored-by: yanziseeker <153156292+AdventureSeeker987@users.noreply.github.com> Co-authored-by: BigSky <77446076+bigsky77@users.noreply.github.com>
--------- Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
…t allowing rust build script to find it when crate is used as a dependency
* Safer smart pointer that covers host and device * Fixed MSM test * Scalars and points in MSM are non-mutable in all cases * change mont API (#332) * Some Rust doc comments --------- Co-authored-by: ChickenLover <Romangg81@gmail.com>
ChickenLover
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.