Release v1.1.0 #357
Merged
Release v1.1.0 #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f using objcopy to modify the symbols
For exposed functions that are curve-specific, the expected symbol is based on the curve name. For example MSMCuda becomes bn254MSMCuda for CURVE=bn254. currently it is implemented via objcopy by redefining symbols after compilation. This PR modifies the function names at preprocessing time instead. For shared objects, objcopy doesn't work (since it cannot modify the dynsym section).
…on (#342) refactor: consolidate msm and batch-msm implementations to one function - now batch-msm support parallel BM accumulation in addition to large triangle accumulation
## Describe the changes This PR allows c++ MSM example to compile with new API ## Linked Issues Resolves #
Add codespell to pre-commit hook/CI and fix typos
- Make the curve config's omegas_count conditionally accessed when creating fields - Remove the extern C function that returns a UDT containing non-POD types and replace it with a default_config function on the Rust bindings side
* BW scalar field is now the same as BLS base field in Rust * G2 fixed and added into Rust
Update README.md
## Describe the changes Make sure the examples comply with new API
| @@ -1,7 +1,9 @@ | |||
| use icicle_bn254::curve::{ | |||
There was a problem hiding this comment.
maybe add a batch MSM example ?
What about an example running in BM and Large triangle accumulation?
Maybe these should be under benchmarks tho not sure.
Please ignore this comment if you dont think we need this.
There was a problem hiding this comment.
Hi @ImmanuelSegol, is there a channel to ask our users what examples they are looking for?
DmytroTym
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release v1.1.0: