Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed overflow in large coset NTTs #358

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Fixed overflow in large coset NTTs #358

merged 3 commits into from
Feb 5, 2024

Conversation

DmytroTym
Copy link
Contributor

@DmytroTym DmytroTym commented Feb 5, 2024 •
edited
Loading

If domain has size 2^17, NTT on size 2^16 coset generated by -1 fails. This happens due to index in BatchMulKernel overflowing, fixed by using long instead of int.

@DmytroTym DmytroTym self-assigned this Feb 5, 2024
@DmytroTym DmytroTym changed the base branch from main to dev February 5, 2024 11:20
@DmytroTym DmytroTym merged commit b13d993 into dev Feb 5, 2024
14 checks passed
@DmytroTym DmytroTym deleted the coset_overflow_fix branch February 5, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshekel yshekel yshekel approved these changes

Assignees

@DmytroTym DmytroTym

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DmytroTym @yshekel