fix: verify NTT size is a power of two #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshekel
force-pushed
the
yshekel/ntt_assert_power_of_two
branch
from
4767111
to
0c083c0
Compare
vhnatyk
reviewed
Feb 14, 2024
icicle/appUtils/ntt/ntt.cu
Outdated
| << "NTT size is too large for the domain. Consider generating your domain with a higher order root of unity" | ||
| << '\n'; | ||
| throw -1; | ||
| std::cerr << "[ERROR] NTT size=" << size |
There was a problem hiding this comment.
use THROW_ICICLE_ERR(
IcicleError_t::InvalidArgument, "error message
There was a problem hiding this comment.
I was not sure since we don't catch it and there is no real reason to crash user app.
Do you think it's better to throw exceptions for wrong user input?
vhnatyk
reviewed
Feb 14, 2024
|
|
||
| int logn = int(log2(size)); | ||
| const bool is_size_power_of_two = size == (1 << logn); | ||
| if (!is_size_power_of_two) { |
yshekel
force-pushed
the
yshekel/ntt_assert_power_of_two
branch
5 times, most recently
from
afaa5a9
to
d37869e
Compare
yshekel
force-pushed
the
yshekel/ntt_assert_power_of_two
branch
from
d37869e
to
03e9057
Compare
yshekel
changed the title
DmytroTym
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.