-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conflicts main #377
Fix conflicts main #377
Conversation
Co-authored-by: hadaringonyama <hadar@ingonyama.com>
Change rust example deps to use paths Co-authored-by: Leon Hibnik <107353745+LeonHibnik@users.noreply.github.com>
Release 1.3.0: * [FEAT] Mixed-radix NTT design * [FEAT] example paths changed
1371c85
to
ba6c3ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm except for the rust-toolchain files that made a comeback :)
If it works then it's not a problem. I see it's only for NTT and MSM examples.
examples/rust/msm/rust-toolchain
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was removed in bindings in dev, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed 'wrappers/rust/rust-toolchain' but I am not sure about this one and the other one in the ntt examples.
This PR fixes the conflicts between main and dev