Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicts main #377

Merged
merged 10 commits into from
Feb 15, 2024
Merged

Fix conflicts main #377

merged 10 commits into from
Feb 15, 2024

Conversation

ChickenLover
Copy link
Contributor

This PR fixes the conflicts between main and dev

jeremyfelder and others added 8 commits February 8, 2024 20:43
Co-authored-by: hadaringonyama <hadar@ingonyama.com>
Change rust example deps to use paths

Co-authored-by: Leon Hibnik <107353745+LeonHibnik@users.noreply.github.com>
Release 1.3.0:
* [FEAT] Mixed-radix NTT design
* [FEAT] example paths changed
Copy link
Collaborator

@yshekel yshekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except for the rust-toolchain files that made a comeback :)
If it works then it's not a problem. I see it's only for NTT and MSM examples.

Copy link
Contributor

@vhnatyk vhnatyk Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was removed in bindings in dev, right?

Copy link
Collaborator

@yshekel yshekel Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed 'wrappers/rust/rust-toolchain' but I am not sure about this one and the other one in the ntt examples.

@DmytroTym DmytroTym merged commit 6854dbf into dev Feb 15, 2024
14 checks passed
@DmytroTym DmytroTym deleted the fix-conflicts-main branch February 15, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants