feature: mixed-radix NTT fast twiddles mode #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -116,7 +123,7 @@ namespace ntt { | |||
| int tid = blockDim.x * blockIdx.x + threadIdx.x; | |||
| if (tid >= n_elements * batch_size) return; | |||
| int64_t scalar_id = tid % n_elements; | |||
| if (rev_type != eRevType::None) scalar_id = generalized_rev(tid, logn, dit, rev_type); | |||
| if (rev_type != eRevType::None) scalar_id = generalized_rev(tid, logn, dit, false, rev_type); | |||
There was a problem hiding this comment.
shouldn't we be passing fast_tw as a parameter here?
There was a problem hiding this comment.
it's the kernel that handles cosets but it doesn't work with the fast-twiddles. That's why I removed the parameter and pass false. Otherwise it would calculate incorrectly.
Update: actually I am not sure why it doesn't work with the fast twiddles. I did not debug.
yshekel
force-pushed
the
fast-twiddles
branch
4 times, most recently
from
bb42693
to
8f36c1c
Compare
- this mode is allocating additional 4N twiddles to achieve faster computation Co-authored-by: hadaringonyama <hadar@ingonyama.com>
… and device arrays
yshekel
force-pushed
the
fast-twiddles
branch
from
8f36c1c
to
9a2957b
Compare
…mean it is initialized but that it is allocated
DmytroTym
approved these changes
Feb 21, 2024
…anyway with one mutex" This reverts commit 77a220c.
Merged
jeremyfelder
added a commit
that referenced
this pull request
Feb 23, 2024
# Contents of this release Examples: multi-gpu example #381 Examples: updates example compares Radix2 and MixedRadix NTTs #383 Feat: add vector operations bindings to Rust #384 Examples: update examples with new vec ops #388 Feat: Grumpkin curve implementation #379 Feat: mixed-radix NTT fast twiddles mode #382 Docs: Update README.md #385 #387 README: Update Hall of Fame section #394 Examples: add rust poseidon example #392 Feat: GoLang bindings for v1.x #386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mode is allocating 4N additional twiddle-factors (where N is max NTT size) for faster compute kernels.