Vec ops docs #402
Closed
Vec ops docs #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update README.md (#385) * refactor * refactor * refactor * rename task * update codespell * multi gpu docs (#391) * Refactor * refacotr * fix typo * Apply suggestions from code review Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com> * refactor * refactor --------- Co-authored-by: DmytroTym <dmytrotym1@gmail.com> Co-authored-by: ChickenLover <Romangg81@gmail.com> Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
| - **`sub`**: Computes the element-wise difference between two vectors. | ||
| - **`mul`**: Performs element-wise multiplication of two vectors. | ||
|
|
||
| ### Argument Validation |
There was a problem hiding this comment.
Remove this part:) check_vec_ops_args is just for internal use, and the user doesn't need to check anything before calling the methods
There was a problem hiding this comment.
I wanted to explain that we implemented this for them, so developers wont think they need to implement it themselves
There was a problem hiding this comment.
Inputs validation is the default thing and we do it in all of our primitives, so I don't think we should mention it in the docs
ChickenLover
requested changes
Feb 28, 2024
bigsky77
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
This PR...
Linked Issues
Resolves #