Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golang docs #413

Merged
merged 30 commits into from
Mar 6, 2024
Merged

golang docs #413

merged 30 commits into from
Mar 6, 2024

Conversation

ImmanuelSegol
Copy link
Contributor

Describe the changes

This PR...

Linked Issues

Resolves #

jeremyfelder
jeremyfelder reviewed Mar 3, 2024
View reviewed changes
docs/sidebars.js Outdated Show resolved Hide resolved
@jeremyfelder
Copy link
Collaborator

Update https://github.com/ingonyama-zk/icicle/blob/main/.github/workflows/deploy-docs.yml#L8 to:

      - 'docs/**'

to ensure the github action runs on all document changes and not just 1 level deep

ImmanuelSegol and others added 6 commits March 3, 2024 08:52
@ImmanuelSegol @jeremyfelder
Update docs/docs/icicle/primitives/ntt.md
65b0722 
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
@ImmanuelSegol @jeremyfelder
Update docs/docs/icicle/primitives/msm.md
7afd3c5 
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
@ImmanuelSegol @jeremyfelder
Update docs/docs/icicle/golang-bindings/msm.md
5259654 
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
@ImmanuelSegol
refactor
6d8c19f
@ImmanuelSegol
refactor
e1375ae
@ImmanuelSegol
refctor
663285b
@ImmanuelSegol ImmanuelSegol marked this pull request as ready for review March 3, 2024 15:17
HadarIngonyama
HadarIngonyama requested changes Mar 3, 2024
View reviewed changes
docs/docs/icicle/primitives/ntt.md Outdated Show resolved Hide resolved
docs/docs/icicle/primitives/ntt.md Show resolved Hide resolved
ImmanuelSegol and others added 5 commits March 4, 2024 12:06
@ImmanuelSegol @jeremyfelder
Update docs/docs/icicle/golang-bindings/ntt.md
38de19b 
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
@ImmanuelSegol @jeremyfelder
Update docs/docs/icicle/golang-bindings/msm.md
7e853f9 
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
@ImmanuelSegol @jeremyfelder
Update docs/docs/icicle/golang-bindings/msm.md
21a57e0 
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
@ImmanuelSegol
refactor
769a848
@ImmanuelSegol
Merge branch 'golang-docs' of https://github.com/ingonyama-zk/icicle …
f82db9f 
…into golang-docs
DmytroTym
DmytroTym reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@DmytroTym DmytroTym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice docs!

docs/docs/icicle/golang-bindings.md Outdated Show resolved Hide resolved
docs/docs/icicle/golang-bindings.md Outdated Show resolved Hide resolved
docs/docs/icicle/golang-bindings/ntt.md Show resolved Hide resolved
docs/docs/icicle/golang-bindings/ntt.md Outdated Show resolved Hide resolved
docs/docs/icicle/rust-bindings/ntt.md Outdated Show resolved Hide resolved
ImmanuelSegol and others added 2 commits March 5, 2024 09:54
@ImmanuelSegol @DmytroTym
Update docs/docs/icicle/rust-bindings/ntt.md
a721bb4 
Co-authored-by: DmytroTym <dmytrotym1@gmail.com>
@ImmanuelSegol @DmytroTym
Update docs/docs/icicle/golang-bindings/ntt.md
3be7ad2 
Co-authored-by: DmytroTym <dmytrotym1@gmail.com>
ImmanuelSegol and others added 6 commits March 6, 2024 07:29
@ImmanuelSegol @DmytroTym
Update docs/docs/icicle/golang-bindings.md
673e679 
Co-authored-by: DmytroTym <dmytrotym1@gmail.com>
@ImmanuelSegol @DmytroTym
Update docs/docs/icicle/golang-bindings.md
16ffbdc 
Co-authored-by: DmytroTym <dmytrotym1@gmail.com>
@ImmanuelSegol @jeremyfelder
Update docs/docs/icicle/golang-bindings/msm.md
b8055d6 
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
@ImmanuelSegol
refactor
72bb9ae
@ImmanuelSegol
merge main
e18ffc5
@ImmanuelSegol
refactor: pull
1cd8b37
@ImmanuelSegol ImmanuelSegol merged commit af6bfc9 into main Mar 6, 2024
22 checks passed
@ImmanuelSegol ImmanuelSegol deleted the golang-docs branch March 6, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmytroTym DmytroTym DmytroTym approved these changes

@jeremyfelder jeremyfelder jeremyfelder approved these changes

@HadarIngonyama HadarIngonyama HadarIngonyama approved these changes

@LeonHibnik LeonHibnik Awaiting requested review from LeonHibnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ImmanuelSegol @jeremyfelder @DmytroTym @HadarIngonyama