Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small features #415

Merged
merged 9 commits into from
Mar 6, 2024
Merged

Small features #415

merged 9 commits into from
Mar 6, 2024

Conversation

ChickenLover
Copy link
Contributor

@ChickenLover ChickenLover commented Mar 3, 2024

This PR is a compilation of small improvements

  • Lock bindgen version for icicle-cuda-runtime
  • Add an error message when trying to build on Mac (or any non windows/linux machine)
  • Add documentation and template files for adding new curve
  • Add documentation on _params.cuh contents
  • Add the script to bump all the rust crates versions to the same version

@ChickenLover ChickenLover marked this pull request as ready for review March 4, 2024 09:53
@ChickenLover
Copy link
Contributor Author

pls check the writing in docs, I am not a good writer:)

docs/docs/icicle/supporting-additional-curves.md Outdated Show resolved Hide resolved
docs/docs/icicle/supporting-additional-curves.md Outdated Show resolved Hide resolved
docs/docs/icicle/supporting-additional-curves.md Outdated Show resolved Hide resolved
docs/docs/icicle/supporting-additional-curves.md Outdated Show resolved Hide resolved
docs/docs/icicle/supporting-additional-curves.md Outdated Show resolved Hide resolved
docs/docs/icicle/supporting-additional-curves.md Outdated Show resolved Hide resolved
docs/docs/icicle/supporting-additional-curves.md Outdated Show resolved Hide resolved
docs/docs/icicle/supporting-additional-curves.md Outdated Show resolved Hide resolved
@ImmanuelSegol
Copy link
Contributor

pls check the writing in docs, I am not a good writer:)

nono you are good lol 10/10 writer

@ChickenLover
Copy link
Contributor Author

@ImmanuelSegol I worked over all of your comments, pls check

Copy link
Contributor

@ImmanuelSegol ImmanuelSegol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs look good

Copy link
Contributor

@DmytroTym DmytroTym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, very satisfying to have lots of small pesky issues solved, good job

docs/docs/icicle/supporting-additional-curves.md Outdated Show resolved Hide resolved
docs/docs/icicle/supporting-additional-curves.md Outdated Show resolved Hide resolved
docs/docs/icicle/supporting-additional-curves.md Outdated Show resolved Hide resolved
docs/docs/icicle/supporting-additional-curves.md Outdated Show resolved Hide resolved
wrappers/rust/icicle-core/src/poseidon/mod.rs Show resolved Hide resolved
@jeremyfelder jeremyfelder linked an issue Mar 6, 2024 that may be closed by this pull request
@jeremyfelder jeremyfelder merged commit 9fc0839 into main Mar 6, 2024
21 checks passed
@jeremyfelder jeremyfelder deleted the small-features branch March 6, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Update Supporting Additional Curves documentation
4 participants