Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go install source in Dockerfile #428

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

cyl19970726
Copy link
Contributor

Describe the changes

The go package resources have been updated in https://go.dev/dl/ and it leads to failure when executing docker build -t icicle-demo .

Copy link
Contributor

@ImmanuelSegol ImmanuelSegol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremyfelder have a look to please

Copy link
Collaborator

@jeremyfelder jeremyfelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to reproduce a failure/error as the old URL redirects correctly but its a good idea to update anyway. Thanks for the contribution 🔥 🚀

@jeremyfelder jeremyfelder merged commit 08ec0b1 into ingonyama-zk:main Mar 10, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants