chunked-msm V3 #562
Merged
chunked-msm V3 #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshekel
force-pushed
the
chunked-msm
branch
2 times, most recently
from
7c82e2c
to
aafbf1c
Compare
yshekel
force-pushed
the
yshekel/V3
branch
6 times, most recently
from
0e2d8e2
to
73dd80b
Compare
HadarIngonyama
force-pushed
the
chunked-msm
branch
from
aafbf1c
to
eb9326a
Compare
| @@ -283,7 +283,7 @@ class Field | |||
| add_limbs(const storage<NLIMBS>& xs, const storage<NLIMBS>& ys, storage<NLIMBS>& rs) | |||
| { | |||
| #ifdef __CUDA_ARCH__ | |||
| return add_sub_limbs_device<NLIMBS, false, CARRY_OUT>(xs, ys, rs); | |||
| return add_sub_limbs_device<NLIMBS, false, CARRY_OUT>(xs, ys, rs); | |||
There was a problem hiding this comment.
Suggested change
| return add_sub_limbs_device<NLIMBS, false, CARRY_OUT>(xs, ys, rs); | |
| return add_sub_limbs_device<NLIMBS, false, CARRY_OUT>(xs, ys, rs); |
yshekel
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the chunked msm feature to V3
cuda-backend-branch: chunked-msm