Emir/poseidon #626
Open
Emir/poseidon #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshekel
reviewed
Oct 10, 2024
| unsigned int alpha; ///< Sbox power. | ||
| unsigned int partial_rounds; ///< Number of upper full rounds of a single hash. | ||
| unsigned int full_rounds_half; ///< Number of partial rounds of a single hash. | ||
| S* round_constants; ///< Round constants (both of the full and the partial rounds). The order of the constants in the memory is according to the rounds order. |
There was a problem hiding this comment.
is the matrices dims known and fixed? if yes, can't we simply define them and then copy the entire struct to GPU as is without an additional indirection
yshekel
reviewed
Oct 10, 2024
| @@ -165,32 +165,1090 @@ TEST_F(HashApiTest, MerkleTree) | |||
| ASSERT_TRUE(verification_valid); | |||
| } | |||
|
|
|||
| #ifdef POSEIDON | |||
| // #ifdef POSEIDON | |||
There was a problem hiding this comment.
why did you remove? we can disable poseidon
yshekel
reviewed
Oct 10, 2024
|
|
||
| PoseidonConstantsInitOptions<scalar_t> options = {}; | ||
|
|
||
| unsigned char poseidon_constants_2[] = { |
There was a problem hiding this comment.
can you maybe randomize it? if we compare CPU to CUDA it should work with any constants right? it should be a more robust test too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.