Update dependencies for December 2020 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added commons-lang3 and made arquillian dependencies optional so they are not transitive
for downstream applications
|
@lprimak Thanks a lot.. Im wondering if I can add your project https://github.com/flowlogix/test-arq-suite as test subproject for extension? |
ingwarsw
approved these changes
Dec 1, 2020
commodis
reviewed
Dec 6, 2020
| @@ -30,6 +29,7 @@ | |||
| import java.util.Set; | |||
| import java.util.logging.Level; | |||
| import java.util.logging.Logger; | |||
| import org.apache.commons.lang3.StringUtils; | |||
There was a problem hiding this comment.
is this import correct? I do not see anything using StringUtils in this commit
There was a problem hiding this comment.
Yes. Line 122 is the usage. Switched from old commons.lang to new commons.lang3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies updated, enforcer plugin tested, compile errors fixed.
Fixes #62