Foreground color broken when background color specified

[dolandemort]

When specifying a background color, any specified foreground color is improperly displayed. To reproduce, use:

/echo -aCblack,Cbgyellow test

The expected result is black font with yellow background, but the actual result is red font with yellow background.

[erikarn]

+1 i just noticed that!

[erikarn]

ah, here:

/ /echo -aCbgblue,BCred Foo!

doesn't work.

/ /echo -aBCred,Cbgblue Foo!

works!

[erikarn]

Ok, I figured out why.

It's because the BG colour flag overlaps with the FG colour variable itself.

diff --git a/src/tf.h b/src/tf.h
index d5bd672..a47d6d8 100644
--- a/src/tf.h
+++ b/src/tf.h
@@ -90,7 +90,8 @@ enum enum_attr {
     F_FGCOLOR     = 0x00000080,   /* flag */
 # define BGCOLORSHIFT 16
     F_BGCOLORMASK = 0x00ff0000,   /* 8 bits, interpreted as an integer */
-    F_BGCOLOR     = 0x00000100,   /* flag */
+    F_BGCOLOR     = 0x80000000,   /* flag (XXX) */
+//    F_BGCOLOR     = 0x00000100,   /* flag - this overlaps with the FG colour */
 #else
     /* inside the 16 low bits */
 # define FGCOLORSHIFT 8
cerise:src adrian$ 

[erikarn]

now, this is a bit terrible because I don't know if the high bit is used, it doesn't LOOK like it from a cursory glance, but that made echo work properly again.

[erikarn]

Pull request is here - #61