Fix cleaning of peer dependencies #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peer dependencies with sub folders where not cleaned so far. The reason for that is that the generated glob was only about the direct sub folder and deeper structures were ignored.
4 tasks
|
I added another commit to significantly speed up the cleanup process. Ping @Trott @silverwind @inikulin |
BridgeAR
force-pushed
the
properly-clean-peer-dependencies
branch
from
a287022
to
8ff17f9
Compare
Currently each target created two glob patterns. Those add up to quite a lot of patterns that must all be checked against a lot of files. This replaces those with a single glob pattern that combines all targets. That reduces the CPU time significantly.
BridgeAR
force-pushed
the
properly-clean-peer-dependencies
branch
from
8ff17f9
to
38fc56d
Compare
|
I updated it further to a single glob pattern. |
Trott
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peer dependencies with sub folders where not cleaned so far. The
reason for that is that the generated glob was only about the direct
sub folder and deeper structures were ignored.