-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parser): Support search element #452
Conversation
Part of our test suite, but not actually part of the spec yet; see whatwg/html#7320
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but weird to merge something that isn’t in HTML.
Is there a way for the tests to only test what is merged?
If not, should such a “feature-flag” be proposed there?
It is a bit odd that this was already added to |
Hello @fb55, I'm the software architect who implemented the Nevertheless, as I see those details won't affect your PR. |
@Kaleidea Thanks a lot for the context! |
The search element is now part of the HTML spec, so let's get this merged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep!! :)
Not sure if this PR should be merged at this time.
The
<search>
element is tested inhtml5lib-tests
, but the PR for the spec hasn't been merged yet (whatwg/html#7320). It seems like there is consensus around this spec change (see whatwg/html#7581), but we might hold off on this until the spec has actually been updated.