test3 workflow

initd1 · Jul 4, 2023 · e01968c · e01968c
1 parent fc3ac2f
commit e01968c
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/.github/workflows/docker-ecr-image-push.yml b/.github/workflows/docker-ecr-image-push.yml
@@ -34,10 +34,10 @@ jobs:
         IMAGE_TAG: ${{ github.sha }}
       run: |
         # Build a docker container and push it to ECR 
-        docker build -t '$ECR_REGISTRY/$ECR_REPOSITORY:latest' shlok-ai/.
-        echo "Pushing image to ECR: $IMAGE_TAG"
-        docker push $ECR_REGISTRY/$ECR_REPOSITORY:latest
-        echo "name=image::$ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG" >> $GITHUB_OUTPUT
+        docker build -t '${{ ECR_REGISTRY }}/${{ ECR_REPOSITORY }}:${{ IMAGE_TAG }}' shlok-ai/.
+        echo "Pushing image to ECR: ${{ IMAGE_TAG }}"
+        docker push ${{ ECR_REGISTRY }}/${{ ECR_REPOSITORY }}:${{ IMAGE_TAG }}
+        echo "name=image::${{ ECR_REGISTRY }}/${{ ECR_REPOSITORY }}:${{ IMAGE_TAG }}" >> $GITHUB_OUTPUT
         
     - name: Build, tag, and push the image to Amazon ECR
       id: build-shlok-api
@@ -47,8 +47,8 @@ jobs:
         IMAGE_TAG: ${{ github.sha }}
       run: |
         # Build a docker container and push it to ECR 
-        docker build -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG .
+        docker build -t ${{ ECR_REGISTRY }}/${{ ECR_REPOSITORY }}:${{ IMAGE_TAG }} .
         echo "Pushing image to ECR..."
-        docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
-        echo "name=image::$ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG" >> $GITHUB_OUTPUT
+        docker push ${{ ECR_REGISTRY }}/${{ ECR_REPOSITORY }}:${{ IMAGE_TAG }}
+        echo "name=image::${{ ECR_REGISTRY }}/${{ ECR_REPOSITORY }}:${{ IMAGE_TAG }}" >> $GITHUB_OUTPUT