CI - PR checks #13
Merged
CI - PR checks #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| done | ||
|
|
||
| - name: test | ||
| run: cargo contract test |
There was a problem hiding this comment.
From use-ink/cargo-contract#958, cargo contract test is removed. Better use cargo test
There was a problem hiding this comment.
@HyunggyuJang This will have to be updated when this repo go to cargo contract 2.0 & ink! 4.0
But right now in cargo contract v2.0.0-rc.1 this is not removed
There was a problem hiding this comment.
Got it. Thanks for the clarification!
|
Also, cargo contract released official v2.0.0. Don't need to cling on rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI checks for all contracts inside the projects.
cargo contract checkcargo testIt is not possible to check contract build/checks at the repository root when having multiple contracts inside a project.
We need to compile them one by one by passing
--manifest-pathoption.