Allow a custom name, not just auto-generated #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This affected @richardcase when a team-mate deleted his VM from a common company cloud account not knowing what it was for, or who it belonged to. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
This commit makes HTTPS tunnels the default, and a TCP tunnel can still be created with --tcp. Tested against digitalocean Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
|
Here's a custom tunnel name, with a HTTPS domain using LE's staging issuer to avoid using up the available rate limit. 
|
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
|
Thanks @alexellis . I just tried this and it works. |
|
Thank you. The release will be available via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow a custom name, not just auto-generated
This affected @richardcase when a team-mate deleted his VM from a common company cloud account not knowing what it was for, or who it belonged to.
How are existing users impacted? What migration steps/scripts do we need?
No change, if you leave the name blank, it works as before.
Checklist:
I've updated the help text for the command.