Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana board + awesome alerts #17

Open
cervajs opened this issue Feb 19, 2024 · 6 comments
Open

grafana board + awesome alerts #17

cervajs opened this issue Feb 19, 2024 · 6 comments

Comments

@cervajs
Copy link

cervajs commented Feb 19, 2024

i have plan publish (if not exist) grafana board and awesome alerts to https://samber.github.io/awesome-prometheus-alerts/

can you share what you have for this exporter now?
thanks

@frittentheke
Copy link
Collaborator

Hey @cervajs, thanks for the interest in this exporter and to gather some dashboards / alerts!
We do have some basic dashboards that we could share in theory. But they would not mixins, but actual JSON exported dashboards then. I'd rather first convert the dashboards (and alerts if they can be generalized) to Grafonnet (https://grafana.github.io/grafonnet/) and then distribute and lifecycle it with the exporter.

Kinda like it's done / attempted for the node-exporter at https://github.com/prometheus/node_exporter/tree/master/docs/node-mixin

Or what are your thoughts on the matter?

@weshouman
Copy link

I have ported the original libvirt-dashboard to work with this implementation, alongside with some parameterization for the job and host names at https://grafana.com/grafana/dashboards/20737-libvirt-dashboard/

@frittentheke
Copy link
Collaborator

@weshouman thanks a lot for your time and work! Would you maybe create a PR to add your dashboard to this repo?

We already discussed adding a dashboard (and maybe even alerts), but would like to move to something along the lines of https://github.com/grafana/grafonnet to have this as mixins which can be kept up to date with Grafana updates and also contains at least some tests to verify things still work.

@frittentheke
Copy link
Collaborator

@weshouman May I kindly ask again if you would push your dashboard as a PR to this project?

@weshouman
Copy link

weshouman commented May 17, 2024 via email

@frittentheke
Copy link
Collaborator

Been busy recently, if I didn't manage to commit it through the month feel free to commit it directly

Message ID: </issues/17/2112826393@ github.com>

No worries. I just refrained from taking things without permission.
A PR is somewhat of a clear sign you are OK to contribute this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants