Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CO-324] Accounts per-field endpoints #3210

Merged

Commits on Jul 6, 2018

  1. [CO-324] Draft endpoints to get accounts' address and balance

    Ideally, we want the /.../account/addresses to be paginated,
    otherwise there's no real value in isolating it as such. Also,
    for now, the implementation is rather heavy and requires the
    full account to be retrieved from the DB. On the long-term, we
    could imagine fetching only the addresses from the DB and
    streaming the response.
    KtorZ committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    1e1c111 View commit details
    Browse the repository at this point in the history
  2. [CO-324] Introduce pagination for getAccountAddresses

    This is not 'ideal' yet because we are sorting and filtering on a plain list.
    Instead, we could have these operation at a DB-level, but this won't probably
    be achieved with acid-state. Perhaps if one day we switch to SQL
    KtorZ committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    930c8c0 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2018

  1. [CO-324] Extend integration test suites for account per-field endpoint

    There was no integration tests for any accounts endpoints :s ... We should work on that in the future as I didn't take care of it
    in this commit / task, but solely add a few one for the newly added endpoints
    KtorZ committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    323d0fc View commit details
    Browse the repository at this point in the history
  2. [CO-324] Write about partial account representations in API doc

    Also, this rename the balance endpoint to '/api/v1/wallets/{id}/accounts/{ix}/amount' to reflect the actual name of
    the field in the Account representation.
    KtorZ committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    83c865e View commit details
    Browse the repository at this point in the history