Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CDEC-425] Weed out unused package dependencies #3240

Merged
merged 4 commits into from
Jul 13, 2018
Merged

Conversation

intricate
Copy link
Contributor

@intricate intricate commented Jul 13, 2018

Description

Remove unneeded package dependencies. I've left out a few packages, which aren't actually compiled, for which weeder claims all of their build-depends are unnecessary.

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/CDEC-425

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

erikd and others added 3 commits July 12, 2018 21:54
Packages: auxx, binary-test, infra-test, wallet-new, wallet
Packages: binary, block, block-test, core, core-test, crypto, delegation-test, explorer, generator, infra, lrc, tools, txp, txp-test, update, update-test, util, util-test
@intricate intricate force-pushed the erikd/CDEC-425 branch 3 times, most recently from cdd010d to cfc7feb Compare July 13, 2018 04:41
Copy link
Member

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@erikd erikd merged commit 4594bc1 into develop Jul 13, 2018
@erikd erikd deleted the erikd/CDEC-425 branch July 13, 2018 07:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants