Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

stack.yaml: Use formatting 6.3.6 from Hackage #3271

Merged
merged 4 commits into from
Jul 19, 2018
Merged

stack.yaml: Use formatting 6.3.6 from Hackage #3271

merged 4 commits into from
Jul 19, 2018

Conversation

erikd
Copy link
Member

@erikd erikd commented Jul 19, 2018

Description

Clean up dependencies

@erikd erikd requested a review from angerman July 19, 2018 04:30
@erikd
Copy link
Member Author

erikd commented Jul 19, 2018

stack2nix failed with:

user error (No such package formatting-6.3.6 in the cabal database. Did you run cabal update?)

This cannot be merged until that is fixed.

@erikd erikd requested a review from iohk-devops as a code owner July 19, 2018 05:37
@erikd
Copy link
Member Author

erikd commented Jul 19, 2018

The stack2nix issue was fixed by updating the Hackage snapshot date in pkgs/generate.sh.

rvl
rvl approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also cherry pick commit 51a2719 into this PR?

angerman
angerman approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erikd
Copy link
Member Author

erikd commented Jul 19, 2018

@rvl I chery-picked that commit

@rvl
Copy link
Contributor

rvl commented Jul 19, 2018 •
edited
Loading

OK thanks. Ignore the AppVeyor status -- see #3272.

@erikd
Copy link
Member Author

erikd commented Jul 19, 2018

i often ignore the AppVeyor status. I usually check why it failed and if it was a bad download restart it once, but for things like build failures due to out-of-memory i ignore it.

@erikd erikd merged commit bf5a683 into develop Jul 19, 2018
@erikd erikd deleted the erikd/formatting branch July 19, 2018 10:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@angerman angerman angerman approved these changes

@rvl rvl rvl approved these changes

@iohk-devops iohk-devops Awaiting requested review from iohk-devops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikd @rvl @angerman