Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CDEC-455] Remove usages of -fno-warn-orphans from update-test #3296

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

intricate
Copy link
Contributor

@intricate intricate commented Jul 24, 2018

Description

This PR simply removes -fno-warn-orphans from ghc-options in cardano-sl-update-test.cabal. All other occurrences of -fno-warn-orphans in this package are all associated with Arbitrary instances (which we've decided to leave as orphans).

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/CDEC-455

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a while to review, but LGTM!

Copy link
Contributor

@mhuesch mhuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@intricate intricate merged commit c562027 into develop Jul 24, 2018
@intricate intricate deleted the intricate/CDEC-455 branch July 24, 2018 23:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants